search

vert-x3 / vertx-mongo-client

Mongo Client for Eclipse Vert.x
http://vertx.io
Apache License 2.0
58 stars 98 forks source link

Collation options improvements and cleanup #273

Closed DarwinsBuddy closed 2 years ago

DarwinsBuddy commented 2 years ago

Motivation:

While using the newly introduced collation options in 4.2.3, I realized that some setters in data object classes are non-compliant to the builder-pattern, which is widely used in the project and also nice to use imho. It's merely syntactical sugar, still, I thought I'd provide a fix for it.

Also add an empty json object fallback on non-provided collation options within IndexOptions

Seemingly, I made a mistake while integrating requested changes of my last PR (#266) in the equals method of CollationOptions. Should be fixed with this commit (alternate is not compared properly)

DarwinsBuddy commented 2 years ago

@tsegismont sry made accidentally a new PR, by renaming my branch. didn't want to cause any troubles by that.

DarwinsBuddy commented 2 years ago

After much back and forth I think I've got the right set of fixes to issues introduced by my latest changes in 4.2.3 (regarding various options and their respective defaults).

@tsegismont if you are still patient enough for another review, I'd very much appreciate your effort :)

vietj commented 2 years ago

done in another PR