search

vert-x3 / vertx-mongo-client

Mongo Client for Eclipse Vert.x
http://vertx.io
Apache License 2.0
58 stars 98 forks source link

Fix #296 Compressors config didn't work #298

Closed siwee closed 1 year ago

siwee commented 1 year ago

Motivation:

Fix #296: Compressors config didn't work

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

tsegismont commented 1 year ago

Thank you @tarvfx

Do you plan to add the documentation and connectivity test with zlib later? We plan to release 4.4 early next week.

siwee commented 1 year ago

Hi, @tsegismont

Thanks for helping me improve the PR. ☕

Happy to follow up, but how do I do the connectivity test? I've used the fix in production and it works fine.

Documentation may need your help (I can try to do it). Because English is not my first language😂.

snappy and zstd depend on third-party artifacts. Do we need to add dependencies (provided scope) in pom.xml?

  <dependency>
    <groupId>com.github.luben</groupId>
    <artifactId>zstd-jni</artifactId>
    <version>1.5.4-1</version>
    <scope>provided</scope>
  </dependency>
  <dependency>
    <groupId>org.xerial.snappy</groupId>
    <artifactId>snappy-java</artifactId>
    <version>1.1.9.1</version>
    <scope>provided</scope>
  </dependency>
tsegismont commented 1 year ago

how do I do the connectivity test?

You can create a test which extends MongoTestBase in src/test/java/io/vertx/ext/mongo The test shall verify that you can connect and make a query using zlib compression.

Documentation may need your help (I can try to do it). Because English is not my first languagejoy.

Sure, you shall edit the src/main/asciidoc/index.adoc file. You can add a new subsection titled Network compression configuration

snappy and zstd depend on third-party artifacts. Do we need to add dependencies (provided scope) in pom.xml?

No, but you shall explain in the doc that users must add these artifacts to their dependencies if they want to support the corresponding compression algorithm.

siwee commented 1 year ago

Hi, @tsegismont

I submitted connectivity tests and documentation. Please review, thanks!

Regards,