search

vert-x3 / vertx-mongo-client

Mongo Client for Eclipse Vert.x
http://vertx.io
Apache License 2.0
58 stars 98 forks source link

callback-based methods are deprecated in vert.x 5 #300

Closed bfreuden closed 1 year ago

bfreuden commented 1 year ago

Motivation:

Callback-based methods are deprecated in vert.x 5 All interfaces methods using AsyncResult<> have been marked @Deprecated Implementation methods have been left as-s

pendula95 commented 1 year ago

Please also add deprecation check for callback in package-info.java. Example https://github.com/vert-x3/vertx-redis-client/pull/366/files#diff-3d6377595bffe2dc8910f690f6146855b22ac86b6f8aecf382956891aa5826ca

vietj commented 1 year ago

@bfreuden you need to update the package-info annotation to @ModuleGen(..., groupPackage = "io.vertx", checkCallbackDeprecation = true)

bfreuden commented 1 year ago

@vietj sorry, I just got your message