vert-x3 / vertx-mqtt

Vert.x MQTT
Apache License 2.0
184 stars 86 forks source link

Unused client options manipulation #203

Open ctron opened 3 years ago

ctron commented 3 years ago

In the constructor of the MQTT client, it looks like some changes in the past have changed the originally intended behavior:

https://github.com/vert-x3/vertx-mqtt/blob/9a91ad811c4e9fbe47306fc2666f9bc4bc8ec33c/src/main/java/io/vertx/mqtt/impl/MqttClientImpl.java#L156-L165

From what I see, the netClientOptions gets copied, manipulated, but then not used at all.