search

vert-x3 / vertx-mqtt

Vert.x MQTT
Apache License 2.0
184 stars 86 forks source link

property is not assigned correctly #211

Closed double-7 closed 2 years ago

double-7 commented 2 years ago

https://github.com/vert-x3/vertx-mqtt/blob/9b8d4ab940c8f58af9e5c168542edb0e67f4fe65/src/main/java/io/vertx/mqtt/impl/MqttEndpointImpl.java#L445

The 'mqttproperties' property is not assigned correctly

vietj commented 2 years ago

can you elaborate ?

double-7 commented 2 years ago

你能详细说明一下吗？ public MqttEndpointImpl subscribeAcknowledge(int subscribeMessageId, List<MqttSubAckReasonCode> reasonCodes, **MqttProperties properties**) { return subscribeAcknowledgeWithCode(subscribeMessageId, reasonCodes.stream().mapToInt(MqttSubAckReasonCode::value).toArray(), **MqttProperties.NO_PROPERTIES**); }

The above is the code I think is defective, and the following is what I fixed

public MqttEndpointImpl subscribeAcknowledge(int subscribeMessageId, List<MqttSubAckReasonCode> reasonCodes, **MqttProperties properties**) { return subscribeAcknowledgeWithCode(subscribeMessageId, reasonCodes.stream().mapToInt(MqttSubAckReasonCode::value).toArray(), **properties**); }

vietj commented 2 years ago

ah right

vietj commented 2 years ago

fixed thanks