vert-x3 / vertx-mqtt

Vert.x MQTT
Apache License 2.0
184 stars 88 forks source link

Rename MqttClientOptions willMessage to willMessageBytes #245

Closed tsegismont closed 11 months ago

tsegismont commented 11 months ago

Backport of PR #244 by @JeffreyThijs

The payload of the will message now requires to be stored in the MqttClientOptions as a String and is afterwards converted to byte[] assuming UTF-8 in the MqttClientImpl when connecting. This is different from the publish methods where a Buffer is required. Additionally, when the will message payload is binary (e.g. in SparkplugB) converting this to a string feels wrong and might lead to unnecessary conversion issues.

tsegismont commented 11 months ago

Fixed by #246