search

vert-x3 / vertx-mqtt

Vert.x MQTT
Apache License 2.0
184 stars 88 forks source link

Support auth message both client side and server side. #248

Closed qianwj closed 4 weeks ago

qianwj commented 4 months ago

Motivation:

At the moment of writing, the vertx-mqtt supports all MQTT version 5.0 features except AUTH message which is yet to be implemented. Now I used it to develop my mqtt broker. So, I try to finished this.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

vietj commented 4 months ago

can you sign the eclipse contributor agreement @qianwj ?

qianwj commented 4 months ago

I just signed it and sorry about that I missed the notice. @vietj

vietj commented 4 months ago

The contribution looks great, can you add documentation for this in index.adoc ?

qianwj commented 3 months ago

done. https://github.com/vert-x3/vertx-mqtt/pull/248/commits/a69174152451cc635f7f6a6f432b1ee448a32353

qianwj commented 3 months ago

hi @vietj , I hope you're doing well. It has been almost a month since I submitted my code changes for review. I understand you might be busy, but I wanted to kindly remind you about my pull https://github.com/vert-x3/vertx-mqtt/pull/248 and request your review.

qianwj commented 2 months ago

done.

ppatierno commented 2 months ago

@vietj is there anything on your side here?

vietj commented 4 weeks ago

thank you @qianwj