Closed qianwj closed 4 weeks ago
can you sign the eclipse contributor agreement @qianwj ?
I just signed it and sorry about that I missed the notice. @vietj
The contribution looks great, can you add documentation for this in index.adoc ?
hi @vietj , I hope you're doing well. It has been almost a month since I submitted my code changes for review. I understand you might be busy, but I wanted to kindly remind you about my pull https://github.com/vert-x3/vertx-mqtt/pull/248 and request your review.
done.
@vietj is there anything on your side here?
thank you @qianwj
Motivation:
At the moment of writing, the vertx-mqtt supports all MQTT version 5.0 features except AUTH message which is yet to be implemented. Now I used it to develop my mqtt broker. So, I try to finished this.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines