vert-x3 / vertx-mysql-postgresql-client

This client is deprecated - use instead
https://github.com/eclipse-vertx/vertx-sql-client
Apache License 2.0
117 stars 59 forks source link

Release idle connections, fixes #33 #136

Closed julianladisch closed 5 years ago

codepitbull commented 5 years ago

@oshai could you take a look at this?

oshai commented 5 years ago

@codepitbull - this change is on the pool which is a separate implementation from jasync itself, I don't know whats the reason the pool from mauricio lib was not used first place. Other than that it looks ok change itself looks ok from what I reviewed.

codepitbull commented 5 years ago

@julianladisch this looks good to go. We just created the new module layout and that caused some conflicts. Could you take a look at the two collision and I'll merge things ASAP.