search

vert-x3 / vertx-mysql-postgresql-client

This client is deprecated - use instead
https://github.com/eclipse-vertx/vertx-sql-client
Apache License 2.0
117 stars 59 forks source link

Add netty native transport support #137

Closed andy-yx-chen closed 5 years ago

andy-yx-chen commented 5 years ago

Add netty native transport support and test cases to cover PreferNativeTransport scenario

vietj commented 5 years ago

I think we need to add test for native transport for Travis CI, you can look at how it is achieved here https://github.com/eclipse-vertx/vert.x/blob/master/.travis.yml . You can test this in your own fork of this repo if you want.

andy-yx-chen commented 5 years ago

I think we need to add test for native transport for Travis CI, you can look at how it is achieved here https://github.com/eclipse-vertx/vert.x/blob/master/.travis.yml . You can test this in your own fork of this repo if you want.

It looks like it's not just as easy as updating the Travis CI script, we need to update maven script as well in this project, will try

andy-yx-chen commented 5 years ago

@vietj , done with setting up another profile to test with nativeTransport, which has better coverage, thanks for the suggestion.

codepitbull commented 5 years ago

Ran the tests (using the Travid commandline) locally on my Ubuntu-box and things look good. LGTM and I will merge it.