Closed okou19900722 closed 5 years ago
Can you provide a test for the situation you are trying to solve with this change?
@Test
public void test(TestContext context){
JsonArray arr = new JsonArray().add(1).add(2);
Async async = context.async();
client.queryWithParams("?", arr, r -> {
context.assertTrue(r.failed());
context.assertTrue(r.cause() instanceof InsufficientParametersException);
async.complete();
});
}
Callback will never be called before modification
I will review everything this weekend to make sure this doesn't introduce breaking changes for current users. Thanks for your effort :)
Hi @codepitbull , have you reviewed yet? It's a terrible problem. can you merge #156 before 3.7.1 release?
Yes, I already merged the other one. Merging this now. Sorry for the delay.
fixed #151