Catch the exception thrown by the synchronization

vert-x3 / vertx-mysql-postgresql-client

This client is deprecated - use instead

Apache License 2.0

117 stars 59 forks source link

Closed okou19900722 closed 5 years ago

vietj commented 5 years ago

can you review this @codepitbull ?

okou19900722 commented 5 years ago

We can switch the default branch to 3.8

codepitbull commented 5 years ago

Sorry, just now got time to take a closer look. PR looks good and I couldn't find a way that would cause problems with the current implementattion.

okou19900722 commented 5 years ago

The callback in the unit test will never be executed until the modification