search

vert-x3 / vertx-mysql-postgresql-client

This client is deprecated - use instead
https://github.com/eclipse-vertx/vertx-sql-client
Apache License 2.0
117 stars 59 forks source link

Changes of jasync were not ported from 3.6 branch to 3.7 and 3.8 #166

Open oshai opened 4 years ago

oshai commented 4 years ago

Hi @codepitbull , I noticed that some PR's were not ported across branches. Is there a reason for that or just something missed some how? Here are few PR examples: https://github.com/vert-x3/vertx-mysql-postgresql-client/pull/154 https://github.com/vert-x3/vertx-mysql-postgresql-client/pull/141

Thanks, Ohad.

codepitbull commented 4 years ago

If PRs are merged before a new version is created they should be part of the new branch.

If PRs are created for older branches I think there should be individual PRs for each branch, especially since the one merging the branch might have tro adjust code to port fixes.

At least that how I handle things normally: If I have to fix something in an older branch I will provide additional PRs for the others (in most cases those are just cherry picks).

oshai commented 4 years ago

Do you want me to do that?