search

vert-x3 / vertx-proton

Apache License 2.0
26 stars 26 forks source link

Alternative changes to #115 #116

Closed gemmellr closed 4 years ago

gemmellr commented 4 years ago

Alternative changes to #115

gemmellr commented 4 years ago

I took your tests from #115 and updated them for the change to detaching, tweaked some of the values used and added some extra checks. I decided just to push those changes in now before I get to the other testing, as I believe a release is planned, and the entire difference sits behind a gating null check anyway and so could be easily avoided if needed.

Pushed to master in https://github.com/vert-x3/vertx-proton/commit/6955463580097a6d18cdc5df17b26c1464f56715 and backported to 3.9 in https://github.com/vert-x3/vertx-proton/commit/4090c6fabf91c5b5380a10220c61c06d240f3fb9.