search

vert-x3 / vertx-rabbitmq-client

Vert.x RabbitMQ Service
Apache License 2.0
73 stars 64 forks source link

Consumer #101

Closed Yaytay closed 4 years ago

Yaytay commented 4 years ago

Motivation:

Fixes #94 and all the changes requested. Has a couple of new changes following stress testing.

Conformance:

Eclipse Contributor Agreement signed.

vietj commented 4 years ago

can you rebase this PR on top of the latest master ? there are conflicts

vietj commented 4 years ago

can you rebase due to conflicts ? also we need documentation in index.adoc

vietj commented 4 years ago

can you add missing documentation ?

Yaytay commented 4 years ago

Hi Julien,

I've added to index.adoc and the examples file. I hope it comes out OK, it's my first use of Ascii Docs.

I also had to tweak one of the unit tests because it was deadlocking, but that was just a case of bringing it into line with master.

Jim

On 29/05/2020 11:58, Julien Viet wrote:

can you add missing documentation ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-rabbitmq-client/pull/101#issuecomment-635910791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA57X2ASRQXNL6FZT6ZQM7LRT6IONANCNFSM4K5P5ERA.

Yaytay commented 4 years ago

Hi Julien,

Have you had a chance to look at the documentation I added?

Thanks

Jim

On 29/05/2020 11:58, Julien Viet wrote:

can you add missing documentation ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-rabbitmq-client/pull/101#issuecomment-635910791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA57X2ASRQXNL6FZT6ZQM7LRT6IONANCNFSM4K5P5ERA.