search

vert-x3 / vertx-rabbitmq-client

Vert.x RabbitMQ Service
Apache License 2.0
73 stars 64 forks source link

#145 #146

Open Yaytay opened 2 years ago

Yaytay commented 2 years ago

Motivation:

Remove @GenIgnore from addConnectionEstablishedCallback

Yaytay commented 2 years ago

Hi @vietj,

Please can you take a look at this, is it OK to remove the @GenIgnore from addConnectionEstablishedCallback? The aim is to make it available to the Rx users. I'm not getting any errors, but I'm not sure that's a good indication in this case :)

If this isn't OK, is there a way to provide a Rx-compatible method that lets the caller register a method that completes asynchronously? Either returning a Future or taking in a Handler would be fine.

Note that the connectionEstablishCallback is called multiple times independently, which prevents some options.

Thanks.