vert-x3 / vertx-redis-client

Redis client for Vert.x
http://vertx.io
Apache License 2.0
129 stars 116 forks source link

Implement tracing and client metrics #392

Closed Ladicek closed 1 year ago

Ladicek commented 1 year ago

Motivation:

Resolves #357

Ladicek commented 1 year ago

If you agree, I'll submit a backport PR against the 4.x branch after this is merged.

Ladicek commented 1 year ago

No idea why the action failed -- the Run tests step succeeds, but then Publish Unit Test Result fails with Error: Resource not accessible by integration :shrug:

Ladicek commented 1 year ago

Rebased.

vietj commented 1 year ago

@Ladicek can you rebase your PR so we can review it next ?

Ladicek commented 1 year ago

Rebased.

Ladicek commented 1 year ago

Added one more commit that improves the replication test, although I'm not sure if that isn't really a deficiency of the replication client :shrug:

Ladicek commented 1 year ago

Removed useless imports, thanks for noticing!

vietj commented 1 year ago

@Ladicek you can merge and backport the PR

Ladicek commented 1 year ago

Backported to 4.x in #398.