vert-x3 / vertx-redis-client

Redis client for Vert.x
http://vertx.io
Apache License 2.0
128 stars 116 forks source link

Fix initialization of RedisOptions and Redis[*]ConnectOptions #428

Closed Ladicek closed 5 months ago

Ladicek commented 7 months ago

This commit makes sure that:

vietj commented 6 months ago

should we have tests for this @Ladicek ?

Ladicek commented 6 months ago

Good point! Let me figure out some tests for this.

Ladicek commented 6 months ago

Added tests. Thanks for insisting on it, I actually discovered a few more subtle bugs -- most importantly, the JSON serialization/deserialization used to get/set the endpoints list multiple times, due to the existence of multiple getter/setter pairs, and that could actually lead to loss of information.

vietj commented 5 months ago

thank you @Ladicek