Closed Ladicek closed 5 months ago
should we have tests for this @Ladicek ?
Good point! Let me figure out some tests for this.
Added tests. Thanks for insisting on it, I actually discovered a few more subtle bugs -- most importantly, the JSON serialization/deserialization used to get/set the endpoints
list multiple times, due to the existence of multiple getter/setter pairs, and that could actually lead to loss of information.
thank you @Ladicek
This commit makes sure that:
RedisOptions
are initialized (initializing them only inRedis[*]ConnectOptions
is not enough due to the usage of copy constructors);RedisConnectOptions
properly delegate to the corresponding superclass constructors;JsonObject
-accepting constructors of subclasses ofRedisConnectOptions
call the correct conversion function, after delegating to the corresponding superclass constructor, which calls its own conversion function;Redis[Connect]Options
classes.