vert-x3 / vertx-redis-client

Redis client for Vert.x
http://vertx.io
Apache License 2.0
128 stars 116 forks source link

[4.x] Fix initialization of RedisOptions and Redis[*]ConnectOptions #429

Closed Ladicek closed 5 months ago

Ladicek commented 7 months ago

This commit makes sure that:

Backport of #428 to 4.x

vietj commented 6 months ago

this seems to contain breaking change ? I can see that the java converters are changed

Ladicek commented 6 months ago

Yes. I can drop the @GenIgnore annotations in this PR, which targets 4.x, because the Vert.x code generator processes properties in alphabetical order, therefore getEndpoints()/setEndpoints() always comes last and no information is lost.

In the corresponding PR to master, the @GenIgnore annotations actually prevent information loss, because the Vert.x codegen processes properties in declaration order. Actually, I can just reorder the getters and setters and don't have to add @GenIgnore.

I'll drop the @GenIgnore annotations here, and in the PR to master, I'll drop the @GenIgnore annotations and reorder the getters/setters.

Ladicek commented 6 months ago

Done, both here and in #428.

vietj commented 5 months ago

@Ladicek can you fix the conflicts for this PR so I can merge it ?

Ladicek commented 5 months ago

Rebased and resolved conflict.