Closed Ladicek closed 5 months ago
this seems to contain breaking change ? I can see that the java converters are changed
Yes. I can drop the @GenIgnore
annotations in this PR, which targets 4.x, because the Vert.x code generator processes properties in alphabetical order, therefore getEndpoints()
/setEndpoints()
always comes last and no information is lost.
In the corresponding PR to master
, the @GenIgnore
annotations actually prevent information loss, because the Vert.x codegen processes properties in declaration order. Actually, I can just reorder the getters and setters and don't have to add @GenIgnore
.
I'll drop the @GenIgnore
annotations here, and in the PR to master
, I'll drop the @GenIgnore
annotations and reorder the getters/setters.
Done, both here and in #428.
@Ladicek can you fix the conflicts for this PR so I can merge it ?
Rebased and resolved conflict.
This commit makes sure that:
RedisOptions
are initialized (initializing them only inRedis[*]ConnectOptions
is not enough due to the usage of copy constructors);RedisConnectOptions
properly delegate to the corresponding superclass constructors;JsonObject
-accepting constructors of subclasses ofRedisConnectOptions
call the correct conversion function, after delegating to the corresponding superclass constructor, which calls its own conversion function.Backport of #428 to 4.x