search

vert-x3 / vertx-redis-client

Redis client for Vert.x
http://vertx.io
Apache License 2.0
128 stars 116 forks source link

Improve javadoc of connection pool options #435

Closed Ladicek closed 5 months ago

Ladicek commented 6 months ago

Fixes #288

Ladicek commented 6 months ago

The recycle timeout was probably meant to be a timeout after which an unused connection is closed and evicted. However, the existing implementation doesn't do that -- it computes expiration time when the connection is created, and then never updates it. This PR just reflects reality.

It shouldn't be hard to fix that -- whenever the connection is returned back to the connection pool, the expiration time would have to be recomputed. That would be enough. I can do that in a 2nd commit in this PR, or separately. Any thoughts?

heubeck commented 5 months ago

:heart_decoration: