search

vert-x3 / vertx-service-discovery

Some tools one can use for doing microservices with Vert.x
Apache License 2.0
115 stars 67 forks source link

Shouldn't use ${project.version} for non project dependencies #104

Closed paulgallagher75 closed 3 years ago

tsegismont commented 3 years ago

@paulgallagher75 can you rebase the PR? That's a lot of commits :-)

paulgallagher75 commented 3 years ago

@paulgallagher75 can you rebase the PR? That's a lot of commits :-)

Yes I messed up when trying to do a different PR and this one seems to have reactivated as its old, I ended up just deleting my fork and recreating the fix I just did, I think it is fine to just close this

tsegismont commented 3 years ago

@paulgallagher75 alright