KubernetesServiceImporter: reconnect if watch gets closed

[tsegismont]

Fixes #113

• removed synchronization on fields; instead, execute importer on context
• replaced WebClient with HttpClient: it is better suited for JSON stream parsing
• use k8s bookmarks if available: avoids re-fetching all history if watch is closed by the server (poll timeout)
• change records list to map: avoids traversing the list over and over again when processing k8s api response
• watch for last known resource version when watch poll request is closed by server
• retrieve and watch again when watch fails for any other reason

[tsegismont]

@vietj @jponge can one of you please review? Thanks!

[tsegismont]

Perhaps in ContextInternal's Javadoc?

Le jeu. 24 juin 2021 à 21:59, Julien Ponge @.***> a écrit :

@.**** commented on this pull request.

LGTM

Is there an easy to reproduce watch being closed in test?

In vertx-service-discovery-bridge-kubernetes/src/main/java/io/vertx/servicediscovery/kubernetes/KubernetesServiceImporter.java https://github.com/vert-x3/vertx-service-discovery/pull/152#discussion_r658241463 :

private static final String OPENSHIFT_KUBERNETES_TOKEN_FILE = "/var/run/secrets/kubernetes.io/serviceaccount/token";

@Override

• public void start(Vertx vertx, ServicePublisher publisher, JsonObject configuration,
• Promise completion) {
• public void start(Vertx vertx, ServicePublisher publisher, JsonObject configuration, Promise completion) {
• context = (ContextInternal) vertx.getOrCreateContext();

Nothing to do with that review, but it makes me think that somehow, somewhere prominent, we should document accessing ContextInternal, why and how.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-service-discovery/pull/152#pullrequestreview-692172722, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALOLNR6PFWLCQ7V3SUFD53TUOFB7ANCNFSM47IJFABQ .