search

vert-x3 / vertx-service-discovery

Some tools one can use for doing microservices with Vert.x
Apache License 2.0
115 stars 67 forks source link

Allow filtering on 'type' in Record.match() #33

Closed aschrijver closed 8 years ago

aschrijver commented 8 years ago

Is there a reason why 'type' is not supported in record filtering? I would like to be able to filter on all Record properties, including 'type'.

https://github.com/vert-x3/vertx-service-discovery/blob/master/vertx-service-discovery/src/main/java/io/vertx/servicediscovery/Record.java#L211

cescoffier commented 8 years ago

There is one reason.... I forgot ;-)

It should be added.

aschrijver commented 8 years ago

Great, thanks!