search

vert-x3 / vertx-service-discovery

Some tools one can use for doing microservices with Vert.x
Apache License 2.0
115 stars 67 forks source link

Annotate the Record in getRecord as @Nullable #87

Closed Mikey-Burns closed 6 years ago

Mikey-Burns commented 6 years ago

This addresses #86 by annotating the ServiceDiscovery#getRecord method as returning a Nullable Record.

cescoffier commented 6 years ago

Looks good to me! Did you sign the Eclipse CLA?

Mikey-Burns commented 6 years ago

@cescoffier Yes, I have signed it with the email burnsm523@gmail.com.

cescoffier commented 6 years ago

Thanks !