search

vert-x3 / vertx-service-proxy

EventBus Proxy generation
Apache License 2.0
67 stars 58 forks source link

Service proxy generation uses deprecated API #104

Closed aygalinc closed 5 years ago

aygalinc commented 5 years ago

Hi,

I notice during some of my build that service proxy generation relies on vert.x deprecated API.

Here is som mvn log : 

ING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxProxyHandler.java:[38,29] io.vertx.serviceproxy.ProxyHelper in io.vertx.serviceproxy has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxEBProxy.java:[31,29] io.vertx.serviceproxy.ProxyHelper in io.vertx.serviceproxy has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxProxyHandler.java:[38,29] io.vertx.serviceproxy.ProxyHelper in io.vertx.serviceproxy has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxEBProxy.java:[31,29] io.vertx.serviceproxy.ProxyHelper in io.vertx.serviceproxy has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxProxyHandler.java:[38,29] io.vertx.serviceproxy.ProxyHelper in io.vertx.serviceproxy has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxEBProxy.java:[31,29] io.vertx.serviceproxy.ProxyHelper in io.vertx.serviceproxy has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxEBProxy.java:[87,22] <T>send(java.lang.String,java.lang.Object,io.vertx.core.eventbus.DeliveryOptions,io.vertx.core.Handler<io.vertx.core.AsyncResult<io.vertx.core.eventbus.Message<T>>>) in io.vertx.core.eventbus.EventBus has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxEBProxy.java:[106,22] <T>send(java.lang.String,java.lang.Object,io.vertx.core.eventbus.DeliveryOptions,io.vertx.core.Handler<io.vertx.core.AsyncResult<io.vertx.core.eventbus.Message<T>>>) in io.vertx.core.eventbus.EventBus has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxEBProxy.java:[125,22] <T>send(java.lang.String,java.lang.Object,io.vertx.core.eventbus.DeliveryOptions,io.vertx.core.Handler<io.vertx.core.AsyncResult<io.vertx.core.eventbus.Message<T>>>) in io.vertx.core.eventbus.EventBus has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxEBProxy.java:[144,22] <T>send(java.lang.String,java.lang.Object,io.vertx.core.eventbus.DeliveryOptions,io.vertx.core.Handler<io.vertx.core.AsyncResult<io.vertx.core.eventbus.Message<T>>>) in io.vertx.core.eventbus.EventBus has been deprecated
[WARNING] /home/caygalin/Workspace/forum-head/gxl.forum.services/target/generated-sources/annotations/com/se/gxl/forum/service/ForumServiceVertxEBProxy.java:[163,22] <T>send(java.lang.String,java.lang.Object,io.vertx.core.eventbus.DeliveryOptions,io.vertx.core.Handler<io.vertx.core.AsyncResult<io.vertx.core.eventbus.Message<T>>>) in io.vertx.core.eventbus.EventBus has been deprecated
castx1981 commented 5 years ago

In *VertxEBProxy, the code is using <T> EventBus send(String address, Object message, DeliveryOptions options, Handler<AsyncResult<Message<T>>> replyHandler); which is marked as deprecated, it should use the request method instead.

@vietj

vietj commented 5 years ago

@castx1981 it should be fixed now in 3.8.1

castx1981 commented 5 years ago

@vietj I checked the 3.8.1 release, it is not fixed, the generated code is still using the deprecated send api.

However it is fixed in the master branch.

vietj commented 5 years ago

oh right @castx1981 I was actually thinking of ProxyHelper class

vietj commented 5 years ago

@castx1981 it should be good now in 3.8 branch

brunobastosg commented 5 years ago

Is this suppposed to be fixed in 3.8.1 or in the next 3.8.x version? I just generated a proxy and it still used the deprecated send method.

vietj commented 5 years ago

it will be in 3.8.2 , you can check yourself with the current 3.8.2-SNAPSHOT published in Sonatype's OSS repo