search

vert-x3 / vertx-service-proxy

EventBus Proxy generation
Apache License 2.0
66 stars 58 forks source link

Supporting Future<T> methods for 4.0 #109

Closed okou19900722 closed 4 years ago

okou19900722 commented 4 years ago

1, ProxyModel.check ReturnType allows to return the value of the Future type, Future's generic type is consistent with the AsyncResult's generic detection. 2, generate a method to return Future in *VertxEBProxy and *VertxProxyHandler 3, unit test fix #107

slinkydeveloper commented 4 years ago

@okou19900722 can you check why test fails?

slinkydeveloper commented 4 years ago

I've adapted the code in vertx-web-api-service too https://github.com/vert-x3/vertx-web/pull/1453, can you give a quick look at it too? If everything is fine, we merge :smile:

slinkydeveloper commented 4 years ago

Done! Are you willing to do a pr to add docs too?

okou19900722 commented 4 years ago

I‘m so sorry. My English is not very good. In order not to produce misunderstood translations, it is best to write documents by others.

slinkydeveloper commented 4 years ago

No problem, I'll do by myself. Thank you again for you contribution!

cvgaviao commented 4 years ago

Hey @slinkydeveloper, could you explain to me the reason for the future support revertion ?

slinkydeveloper commented 4 years ago

The reason is that the feature was buggy and had different problems when used in conjunction with other vertx code generators (eg vertx rx generator). Since we're in the process of releasing a new milestone, we decided to revert it in order to avoid releasing a buggy feature. We really think this is an important feature and we hope to redesign it properly for vertx 4 (suggestions welcome)

cvgaviao commented 4 years ago

I'm not using rxjava, and this was working nicely for me and currently, I have many services using it. Seems that I'll be obligated to use my own branch built jar :(

slinkydeveloper commented 4 years ago

I'm not using rxjava, and this was working nicely for me and currently, I have many services using it. Seems that I'll be obligated to use my own branch built jar :(

We're sorry for it :(, we hope to find a solution before vertx 4 final release

vietj commented 4 years ago

we are trying to find what is the best solution that we can support for the lifetime of Vert.x 4

On 5 Jun 2020, at 14:17, Francesco Guardiani notifications@github.com wrote:

I'm not using rxjava, and this was working nicely for me and currently, I have many services using it. Seems that I'll be obligated to use my own branch built jar :(

We're sorry for it :(, we hope to find a solution before vertx 4 final release

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-service-proxy/pull/109#issuecomment-639445962, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXDCQ242UG6HLPP3JW7ITRVDO45ANCNFSM4JHEYDXQ.

cvgaviao commented 4 years ago

I'm not using rxjava, and this was working nicely for me and currently, I have many services using it. Seems that I'll be obligated to use my own branch built jar :(

We're sorry for it :(, we hope to find a solution before vertx 4 final release

Its ok, I was able to generate the necessary jars and published them to an internal repository in order to continue with our new project using future instead of a callback.

Btw, Its there issues created for those problems you have quoted above? If yes, could you point me to them?

slinkydeveloper commented 4 years ago

Btw, Its there issues created for those problems you have quoted above? If yes, could you point me to them?

Lemme dump them in the #107