search

vert-x3 / vertx-service-proxy

EventBus Proxy generation
Apache License 2.0
67 stars 58 forks source link

vertx-codegen is a required dependency #44

Closed jponge closed 7 years ago

jponge commented 7 years ago

Depending on vertx-serviceproxy alone does not make vertx-codegen available from the application classpath, which is required for annotations like @ProxyGen.

This change updates the documentation.

cescoffier commented 7 years ago

Superseded by #47

jponge commented 7 years ago

...

cescoffier commented 7 years ago

@jponge it's superseded, right? Or I miss something.

cescoffier commented 7 years ago

@jponge if you wonder about the won't fix label it's just to not include this one in the release notes. Not the best label I agree, just need a hints to exclude it.

jponge commented 7 years ago

Yeah, it's just that I had a fix in November ;-)

On Wed, Jan 4, 2017 at 9:23 AM, Clement Escoffier notifications@github.com wrote:

@jponge https://github.com/jponge it's superseded right? Or I miss something.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-service-proxy/pull/44#issuecomment-270317808, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlaR0ovzS_nR2It0P-tlB1fW6QWvGaks5rO1b_gaJpZM4K2jt0 .

cescoffier commented 7 years ago

@jponge If an issue is pending for more than 1 week, send a "ping" on vertx-dev. Something things leave my radar without notice.

tsegismont commented 7 years ago

@jponge sorry I did not notice the PR when I created the issue. I sent an email to the user forum earlier this week and we agreed to document that codegen is needed for implementing but not using service proxies.

2017-01-04 9:26 GMT+01:00 Clement Escoffier notifications@github.com:

@jponge https://github.com/jponge If an issue is pending for more than 1 week, send a "ping" on vertx-dev. Something things leave my radar without notice.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-service-proxy/pull/44#issuecomment-270318452, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbltg8ejN81lJAMfFQuXPbANkdzSDhFks5rO1fOgaJpZM4K2jt0 .

jponge commented 7 years ago

That's ok folks, it happens to have things going under the radar in front of an avalanche of email notifications 😉

cescoffier commented 7 years ago

if it would be only emails.... :-)