change the name of Generator

vert-x3 / vertx-service-proxy

EventBus Proxy generation

Apache License 2.0

66 stars 58 forks source link

change the name of Generator #77

Closed okou19900722 closed 5 years ago

okou19900722 commented 5 years ago

Hi, the name of mvel generator is service_proxies , and after removing mvel it becomes two unrelated names. If you keep these two names, this will be break change

https://github.com/vert-x3/vertx-service-proxy/blob/b06327d4f659102528313c25a8429ce61ba11c12/src/main/resources/codegen.json#L1-L14

okou19900722 commented 5 years ago

If this pr is not merged, then another pr needs to be committed, and it needs to change the implementation of FILTER in ServiceProxyProcessor.

https://github.com/vert-x3/vertx-service-proxy/blob/9e4d89920852771c7fe8ea9bebdeaf13208832c3/src/main/java/io/vertx/serviceproxy/generator/ServiceProxyProcessor.java#L30-L32

okou19900722 commented 5 years ago

It no longer needs