vert-x3 / vertx-stack

Vert.x stack
Apache License 2.0
120 stars 48 forks source link

Add missing javassist dependency #15

Closed cescoffier closed 9 years ago

cescoffier commented 9 years ago

Thymeleaf template engine requires Javassist.

We need to add this dependency again:

<dependency>
    <groupId>org.javassist</groupId>
    <artifactId>javassist</artifactId>
    <version>3.18.2-GA</version>
</dependency>

This dependency needs to be added into the web stack. We need an automated example to check the fix.

purplefox commented 9 years ago

We need to be very careful about that as Netty can behave differently if Javassist is on the classpath and requires a specific version.

cescoffier commented 9 years ago

Yes,

Previously we depended on 3.18.1-GA. We removed it when we dropped the mysql/posgres client. The safest would be to reuse the same version.