vert-x3 / vertx-stack

Vert.x stack
Apache License 2.0
120 stars 48 forks source link

Use the Vert.x log wrapper instead of java.util.logging.Logger #34

Closed mguillet closed 8 years ago

mguillet commented 8 years ago

Any reason we are using java.util.logging.Logger instead of io.vertx.core.logging.Logger ?

I could spot several uses of java.util.logging.Logger for instance in io.vertx.maven.resolver.ResolverImpl.

This break our nice logs since we're using SLF4J instead of JUL.

I can easily make the change and a PR if this change to Vert.x logger is accepted.

Thanks!

cescoffier commented 8 years ago

In the Resolve command ? We could change that without any issue.

mguillet commented 8 years ago

Here are all the classes using JUL classes instead of Vert.x ones:

stack-manager/src/main/java/io/vertx/stack/model/StackResolution.java
stack-manager/src/main/java/io/vertx/stack/resolver/ResolverImpl.java
stack-manager/src/main/java/io/vertx/stack/utils/Cache.java
stack-manager/src/test/java/io/vertx/stack/utils/LocalRepoBuilder.java

Is that OK for all of them to change?

cescoffier commented 8 years ago

Yes.