search

vert-x3 / vertx-stack

Vert.x stack
Apache License 2.0
120 stars 48 forks source link

May vertx-stack/stack-npm/src/main/npm/client/package.json include sockjs as dependency? #37

Closed ghost closed 8 years ago

ghost commented 8 years ago

Hello, may package.json list sockjs-client as a dependency? Then when installed via npm install vertx3-eventbus-client it would install sockjs-client under its local node_modules directory, which is helpful when developing for client javascript using browserify or webpack.

cescoffier commented 8 years ago

@pmlopes : what do you think ?

pmlopes commented 8 years ago

I think that is a good idea. We might need to review the examples though...

cescoffier commented 8 years ago

Should it be considered as a breaking change ?

pmlopes commented 8 years ago

i don't think so, i've not tested it but i think that if we add the dependency to the package.json and the already existing projects would also add the dependency npm should be smart and just use one of the dependencies right? In the worst case there will be 2 downloads of the same dependency on the client side which is not a big deal since at runtime only 1 will be used.

cescoffier commented 8 years ago

Ok, I will apply it.