search

vert-x3 / vertx-stack

Vert.x stack
Apache License 2.0
120 stars 48 forks source link

support ubuntu & alpine base docker image #47

Closed subicura closed 8 years ago

subicura commented 8 years ago

Hello! Vertx3 docker images is only served alpine based image. Alpine based image is small. But alpine has some problem about shared library.

Caused by: java.lang.UnsatisfiedLinkError: /tmp/snappy-1.0.5-libsnappyjava.so: Error loading shared library libstdc++.so.6: No such file or directory (needed by /tmp/snappy-1.0.5-libsnappyjava.so)

Most official docker images support ubuntu(or centos) and alpine. (You can find at https://hub.docker.com/_/java/) It's better to use both base image. So I've added both image build setting. Please review this! Thanks.

cescoffier commented 8 years ago

Hi,

I looked at your PR. As I was replacing the maven plugin we are using to build the docker images (and also wanted to implement some tests, because.... well...), I've integrated your contribution there: https://github.com/vert-x3/vertx-stack/tree/replace-docker-maven-plugin

Can you have a look and tell me if it's ok for you ?

BTW, as it breaks compatibility, as the "regular" (understand no suffix) image was using alpine, we need to wait 3.4.0 before merging these changes.

subicura commented 8 years ago

Hi, @cescoffier. replace-docker-maven-plugin branch looks good! Thanks!

cescoffier commented 8 years ago

Thanks for the feedback @subicura. I'm going to close this PR, and open a new one from my branch.