search

vert-x3 / vertx-stack

Vert.x stack
Apache License 2.0
120 stars 48 forks source link

Add new module vertx-micrometer-metrics #77

Closed jotak closed 6 years ago

jotak commented 6 years ago

Dependant on https://github.com/vert-x3/vertx-dependencies/pull/9 (which should be merged first) and snapshots deployment by CI

Note: tests are failing but seem unrelated to the component being added:

Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 258.406 sec <<< FAILURE! - in io.vertx.stack.VertxStacksTest
testConvergence(io.vertx.stack.VertxStacksTest)  Time elapsed: 150.457 sec  <<< ERROR!
io.vertx.stack.model.DependencyConflictException: Conflict detected for artifact org.apache.zookeeper:zookeeper:jar - version 3.4.9 was already selected while io.vertx:vertx-kafka-client:jar:3.5.1-SNAPSHOT depends on version 3.4.10
    at io.vertx.stack.model.StackResolution.lambda$resolve$4(StackResolution.java:177)
vietj commented 6 years ago

ignore the convergence test, it's not reliable

jotak commented 6 years ago

@vietj I updated this PR for vertx-micrometer-metrics Though the maven version of vertx-micrometer-metrics is still 3.5.1-SNAPSHOT whereas here master is on 3.6.0-SNAPSHOT. So is the plan still to update the 3.5.1 release with vertx-micrometer-metrics, or do I move vertx-micrometer-metrics forward to 3.6?

vietj commented 6 years ago

we're going first to release 3.5.1 and then update for 3.6, there will be some work for 3.6 for integrating in the stack

jotak commented 6 years ago

@vietj : build success It needs https://github.com/vert-x3/vertx-dependencies/pull/9 first

vietj commented 6 years ago

I think first we need to have it also in https://github.com/vert-x3/vertx-base-stack so the api is available in all langs + rx