vert-x3 / vertx-stack

Vert.x stack
Apache License 2.0
120 stars 48 forks source link

Docker clustering configuration docs: -cp implementation inconsistency #82

Closed StephenOTT closed 11 months ago

StephenOTT commented 6 years ago

Hey

looking at: http://vertx.io/docs/vertx-docker/#_clustering

Trying to understand the reason for generating a dynamic class path in the docs example:

To build a dynamic classpath from all the file contained in $VERTICLE_HOME you can use:....

In each of the dockerfile examples in the docs you use:

CMD ["exec vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"] where the -cp is using $VERTICLE_HOME/*. assuming that * provides "everything" in $VERTICLE_HOME logic.

Looking at http://vertx.io/docs/vertx-core/js/#_the_vertx_command_line, there does not appear to provide usage of *, so is this just out of date docs on docker + vertx command line usage?

happy to provide PRs as always for doc updates. Just trying to understand the various usages based on the docs.

Thanks!

tsegismont commented 6 years ago

I don't believe wildcards in classpath definition works. That said, the solution proposed seems complex to me. A simple vertx.hazelcast.config sysprop pointing to the cluster.xml file would do.

StephenOTT commented 6 years ago

@tsegismont, if the * does not work, then should the docker stack examples be updated?

tsegismont commented 6 years ago

@StephenOTT mm indeed, I wasn't aware of that. Can you confirm @cescoffier ? Why this complex dynamic classpath thing then?

cescoffier commented 6 years ago

I used "*" without trouble. Can you provide an example? It may depend on the CMD command

StephenOTT commented 6 years ago

@cescoffier, see the the first post: https://github.com/vert-x3/vertx-stack/issues/82#issue-298122631

The question is related all of the docker examples in vertx/examples having the /* in them. also the docs have the same examples.

@cescoffier are you suggesting that the -cp argument supports wildcards?

tsegismont commented 11 months ago

Closing, Docker images are no longer provided anyway