search

vert-x3 / vertx-stomp

STOMP client/server implementation
Apache License 2.0
31 stars 28 forks source link

Fix the heartbeat issue #40 #42

Closed deepsleep closed 6 years ago

deepsleep commented 6 years ago

  1. Fix issue #40 found in both StompClientConnectionImpl and DefaultStompHandler.

  2. Add unit test testAsymmetricHeartbeatTime to StompClientImplTest.

cescoffier commented 6 years ago

@deepsleep did you sign the Eclipse CLA?

deepsleep commented 6 years ago

@cescoffier Sorry that I am not sure about that, since it's my first PR in Github. And sure I would like to sign the Eclipse CLA.

cescoffier commented 6 years ago

@deepsleep you just have to create an account and sign the CLA on https://accounts.eclipse.org/user/login?destination=user/eca.

The value behind this extra step is to be sure that the contribution is "cleared" in term of IP. You sign the CLA only once for all your contribution to Eclipse projects.

deepsleep commented 6 years ago

Thanks @cescoffier. I have signed the Eclipse CLA. And my email address of Eclipse account is jfcheng87@gmail.com . Thanks again. :)