vert-x3 / vertx-stomp

STOMP client/server implementation
Apache License 2.0
31 stars 28 forks source link

Fix #76 Do not add a receipt handler to PING Frames, as this will cause a memory leak. #77

Closed DevMcC closed 1 year ago

DevMcC commented 1 year ago

76 PING Frames would normally include a receipt handler, which never get resolved, so you will end up with an ever-increasing list of pending receipts.

Passing null as the receipt handler should prevent the creation of a pending receipt.

vietj commented 1 year ago

thanks, but that does not fix the issue that an user might send a PING frame on purpose and create leak the receipt handler. I created two PR's to fix that at the send level.