vert-x3 / vertx-stomp

STOMP client/server implementation
Apache License 2.0
31 stars 28 forks source link

WebSocket writes are binary only #85

Open freynder opened 1 year ago

freynder commented 1 year ago

I'm trying to send a JSON payload with websocket transport from server to client. The message is always sent as binary, even though the payload is text. This may cause compatibility issues with other libraries that expect text payloads for content type application/json, such as Krossbow. At least we should be able to specify the desired payload type.

I traced the call stack to StompServerWebSocketConnectionImpl::write which calls socket.writeBinaryMessage, I don't see any possiblity to enforce sending as text.

vietj commented 1 year ago

@freynder are you interested in contributing an improvement ?

freynder commented 1 year ago

@vietj I'm interested, but looks like this is not a small task and may require core breaking changes as well (to support on the receiving side):

An alternative is to only concentrate on the sending part. That part should be rather simple and less invasive.