search

vert-x3 / vertx-tcp-eventbus-bridge

Apache License 2.0
50 stars 44 forks source link

RECIPIENT_FAILURE missing for bridge client consumers #44

Closed wem closed 5 years ago

wem commented 6 years ago

Version

Missing common event bus failure handling for consumers placed on bridge clients. There is no way to get a ReplyException on a server-side sender in the case of a recipient failure on a bridge client consumer.

EddieParis commented 5 years ago

Hi ! I have same issue, I made a slight protocol modification, i.e. to fail a message, you have to make a regular 'send' command but if the field 'failureCode' is present the TCPEventBusBridge code will fail the message. Pushed on my fork, I'll issue a pull request after some friend's review even if it is light touch modifications.

vngantk commented 5 years ago

I have this problem too. I have reviewed @EddieParis' pull request, and it looks fine to me. When will it be merged and available for release?

vietj commented 5 years ago

@vngantk it should be in 3.7

vietj commented 5 years ago

sorry for late reply @wem

wem commented 5 years ago

Hi No problem, it would be nice when this will be part of 3.7 and so an "official way" is there.

vietj commented 5 years ago

yes it shall be