search

vert-x3 / vertx-tcp-eventbus-bridge

Apache License 2.0
50 stars 44 forks source link

Fix #44 and fix the delivery options parsing. #48

Closed EddieParis closed 5 years ago

vietj commented 5 years ago

I've done a couple of comments for review, it shall be merged in 3.7

vietj commented 5 years ago

@EddieParis can you address the minor PR concerns before we can merge it ?

vietj commented 5 years ago

fixes https://github.com/vert-x3/vertx-tcp-eventbus-bridge/issues/44

vietj commented 5 years ago

@pmlopes can you review this PR ? I want to be sure it is correct protocol wise

vietj commented 5 years ago

thanks for the contribution and the review!