Error Message seems to be send twice - Githubissues

vert-x3 / vertx-tcp-eventbus-bridge

Apache License 2.0

49 stars 44 forks source link

Error Message seems to be send twice #49

Closed aygalinc closed 4 years ago

aygalinc commented 5 years ago

Version

vert.x core: 3.6.3
vert.x tcp eventbus bridge: 3.6.3

Context

I think this piece of code look suspicious :

https://github.com/vert-x3/vertx-tcp-eventbus-bridge/blob/8ae9e760aa8f0e0df5ed03a5421f3a2416301f18/src/main/java/io/vertx/ext/eventbus/bridge/tcp/impl/TcpEventBusBridgeImpl.java#L253-L282

Do you don't think that sendErr message can be send twice ? Inside the lambda and after call checkHook ?

I suggest to remove : https://github.com/vert-x3/vertx-tcp-eventbus-bridge/blob/8ae9e760aa8f0e0df5ed03a5421f3a2416301f18/src/main/java/io/vertx/ext/eventbus/bridge/tcp/impl/TcpEventBusBridgeImpl.java#L271-L279