search

vert-x3 / vertx-tcp-eventbus-bridge

Apache License 2.0
49 stars 44 forks source link

[Issue-52] Improve tests #53

Closed gaol closed 4 years ago

gaol commented 4 years ago

Introduce SSLKeyPairCerts.java to generate SSL key pairs and certificates instead of having the keystore files

Motivation: Fixes: #52

gaol commented 4 years ago

@vert-x3/committers would anyone please review ? Thanks :)

gaol commented 4 years ago

@vietj @pmlopes this PR tries to add bouncycastle to the test scope dependency, and generate the ssl key pairs and certificates when executing the tests. The benefit is that we don't need to worry about the certificate expired some day. What do you think about this? :)

pmlopes commented 4 years ago

I think this is ok, it's a test dependency so not an issue for the end user.