search

vert-x3 / vertx-tcp-eventbus-bridge

Apache License 2.0
49 stars 44 forks source link

Implement JSONRPC as wire protocol #64

Closed gracebish closed 3 years ago

gracebish commented 3 years ago

Motivation:

Explain here the context, and why you're making that change, what is the problem you're trying to solve. -Removed a trailing space. -Added a test to give feedback if test passes or fails. cc. @pmlopes Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

gracebish commented 3 years ago

I need to make improvements on this issue.

pmlopes commented 3 years ago

You can also convert the pr to draft mode. In this case only you get notifications and when you feel it's ready for a review remove the draft and we all get notified.