Support MVEL variable resolver again

vert-x3 / vertx-web

HTTP web applications for Vert.x

Apache License 2.0

1.11k stars 535 forks source link

Support MVEL variable resolver again #2548

Closed tsegismont closed 11 months ago

tsegismont commented 11 months ago

There was a regression introduced in #468. The user-supplied variables were passed to the template engine with a MapVariableResolverFactory and we switched to a context object.

For this reason, it was no longer possible to declare variables in template files.

In this PR, we invoke the template engine with a MapVariableResolverFactory again, instead of the ImmutableDefaultFactory (which prevents from declaring variables).

tsegismont commented 11 months ago

Intermittent failure, will file an issue for that