vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

WebClientTestBase#setup should not recreate the Http Client #2575

Closed tsegismont closed 9 months ago

tsegismont commented 9 months ago

It's already setup in the setup method of the parent test class. And when this is called by a shared client test, Vert.x counts 2 shared client instances.

Consequently, some tests which rely on closing the original http client before creating another one may not work.