search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

`WebClient.close()` does not return a `Future` or wait for resources to be released #2578

Open mcanalesmayo opened 8 months ago

mcanalesmayo commented 8 months ago

Version

4.3.3~

Context

Call to WebClient.close() does not wait for resources to be released. Method signature was changed so that it returns a Future<Void> here https://github.com/vert-x3/vertx-web/pull/2197 But later was reverted here https://github.com/vert-x3/vertx-web/commit/8dda3dec91648eddae01455b8a94cc1c0e25c864 I'd expect .close() to either return the Future<Void>, or (less ideally) block until the future finishes before returning.

Do you have a reproducer?

https://github.com/vert-x3/vertx-web/pull/2197#issuecomment-1150703458 https://github.com/vert-x3/vertx-web/commit/8dda3dec91648eddae01455b8a94cc1c0e25c864

Steps to reproduce

N/A

Extra

N/A

tsegismont commented 8 months ago

@vietj can you give some context about why the futurization change was reverted?

vietj commented 8 months ago

I think because it was a breaking change, but well

mcanalesmayo commented 7 months ago

@tsegismont @vietj so is there any plan to change it again to return the future?

vietj commented 7 months ago

yes I think we should