search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

Fixed docs of vertx-web #2598

Open ShivamPansuriya opened 7 months ago

ShivamPansuriya commented 7 months ago

Changes in vertx-web/src/main/asciidoc/index.adoc @line-250,251

Motivation: There was a contradictory statement in vertx-web docs at #routing-by-exact-path.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

vietj commented 7 months ago

@pmlopes can you double check this ? I am not sure

ShivamPansuriya commented 7 months ago

What is required for me to get necessary legal agreements? @vietj @pmlopes

tsegismont commented 7 months ago

What is required for me to get necessary legal agreements? @vietj @pmlopes

You must sign the Eclipse Contributor Agreement and invoke git commit with -s (signoff), assuming git config user.email and author.email are set to the email address provided when signing the contributor agreement.

ShivamPansuriya commented 7 months ago

What is required for me to get necessary legal agreements? @vietj @pmlopes

You must sign the Eclipse Contributor Agreement and invoke git commit with -s (signoff), assuming git config user.email and author.email are set to the email address provided when signing the contributor agreement.

thanks for the help. it worked for me.