search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

Use the new `OAuth2AuthorizationURL` in `OAuth2AuthHandler.extraParams` #2602

Open fbuetler opened 6 months ago

fbuetler commented 6 months ago

Version

4.5.7

Context

With the deprecation of String OAuth2Auth.authorizeURL(JsonObject params) and the hint to rather use String OAuth2Auth.authorizeURL(OAuth2AuthorizationURL url), the OAuth2AuthHandler OAuth2AuthHandler.extraParams(JsonObject extraParams) should also prefer the new type instead of accepting a JsonObject as they are closely related and for improved type safety.

https://github.com/eclipse-vertx/vertx-auth/blob/6d63ba27e779810b8ebd5af3c59d9d77fd6037dd/vertx-auth-oauth2/src/main/java/io/vertx/ext/auth/oauth2/OAuth2Auth.java#L131-L153

https://github.com/vert-x3/vertx-web/blob/6b093c0947e018e2244bbe2a8cf661867c818710/vertx-web/src/main/java/io/vertx/ext/web/handler/OAuth2AuthHandler.java#L65-L72