search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

fix: When reroute() is called, timeout is always (#2617) #2619

Closed ListenV closed 5 months ago

ListenV commented 6 months ago

See #2617

tsegismont commented 6 months ago

Thanks for the PR.

Have you signed the Eclipse Contributor agreement?

ListenV commented 6 months ago

Thanks for the PR.

Have you signed the Eclipse Contributor agreement?

No, but I just agreed to the Eclipse Contributor agreement. image

ListenV commented 5 months ago

This is not correct. To fix the reroute, we would need to cancel the timer when the roroute happens.

For example, iterate the body end handler and if there is a timer, cancel, as well as remove it.

I'm sorry. I don't know enough about Vertx, and this issue may be beyond my reach. I hope someone else will solve this bug.

tsegismont commented 5 months ago

@ListenV thanks for giving a try

@pmlopes @ListenV here's a possible fix https://github.com/vert-x3/vertx-web/pull/2621