Fix NPE in ForwardedParser#authority()

vert-x3 / vertx-web

HTTP web applications for Vert.x

Apache License 2.0

1.11k stars 535 forks source link

Fix NPE in ForwardedParser#authority() #2630

Closed b8b closed 2 months ago

b8b commented 4 months ago

In vertx-core, HttpServerRequest#authority() and HttpServerRequest#scheme() are marked as @Nullable.

This patch fixes NPEs in vertx-web HttpServerRequestWrapper#authority() and HttpServerRequestWrapper#scheme() that can be triggered for example when called from within a failure handler on an HTTP/1.0 request.

See also #2629

tsegismont commented 4 months ago

Can you please sign the Eclipse Contributor Agreement and then sign-off your commit? Thank you

tsegismont commented 3 months ago

@b8b do you need any help with signing the contributor agreement?

pendula95 commented 3 months ago

@b8b thank you for the contribution and the fix. I am facing the same issue and I am really keen on this merging and getting released. Can you please take a few minutes and sign the contribution agreement? Much appreciated!

tsegismont commented 2 months ago

Superseded by #2640