search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

Added support for vertx-auth-webauth4j #2655

Open FroMage opened 1 month ago

FroMage commented 1 month ago

Requires https://github.com/eclipse-vertx/vertx-auth/pull/692 and https://github.com/vert-x3/vertx-dependencies/pull/197

FroMage commented 1 month ago

This won't pass CI before the two other PRs are merged.

vietj commented 1 month ago

thanks @FroMage

vietj commented 1 month ago

@FroMage you should rebase this PR onto latest master

vietj commented 1 month ago

@FroMage I think we are missing a require static for examples to pass, I know examples should not require a require and I will try to find a solution to remove those later that is global to all projects

FroMage commented 1 month ago

Yeah, I should have compiled before rebasing and pushing :)

FroMage commented 1 month ago

That's not enough, now I get:

[ERROR] Error occurred during initialization of boot layer
[ERROR] java.lang.module.FindException: Module com.fasterxml.jackson.databind not found, required by com.fasterxml.jackson.datatype.jsr310

Perhaps vertx-auth-webauthn4j should declare this module, even though it's actually used by webauthn4j, it probably doesn't have the right dependencies declared since it's an automatic module?

FroMage commented 1 month ago

Oh, probably vertx-auth-webauthn4j should export the webauthn4j module since it's used in the API?

FroMage commented 1 month ago

That's not it either

FroMage commented 1 month ago

Oh, it's the tests, there's a classpath exclusion for jackson-databind when running the tests.

FroMage commented 1 month ago

So, it's due to https://github.com/vert-x3/vertx-web/blob/master/vertx-web/pom.xml#L132-L134 If I comment it out, the tests run. But I suppose that's there for a reason. Any advise @vietj ?

vietj commented 4 weeks ago

@FroMage I think the databind exclusion comes from https://github.com/vert-x3/vertx-web/commit/494f006722b0e68c5d068dab3576e1a87940fd11

vietj commented 4 weeks ago

why is jackson databind needed @FroMage ?

vietj commented 4 weeks ago

I see that webauthn4j has dependency on databind, is that something the project can avoid ?

FroMage commented 4 weeks ago

I see that webauthn4j has dependency on databind, is that something the project can avoid ?

I suppose not, it's using its JSON and CBOR mapping internally.

FroMage commented 2 weeks ago

Any news?

vietj commented 2 weeks ago

it's on my radar :-)

vietj commented 2 weeks ago

I believe also that webauthn4j now supports explicit java modules