search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

Always return a 415 if the content type is mismatching, also if its value is empty #2657

Closed komape closed 1 month ago

komape commented 1 month ago

Motivation:

Solves the bug described in #2656. Instead of returning a 400 in case of a missing content type, it now returns a 415. For further details, see the issue.

It does not add the return of an Accept header in case of a mismatched content type. But I would not see this as a bug but rather as an enhancement which needs its own issue.

Currently waiting for an account with the Eclipse Foundation but they currently experience issues with user sign up. I will sign the ECA as soon as possible.

EDIT: Signed the ECA.

tsegismont commented 1 month ago

@komape could you take care of backporting to 4.x? Thanks

komape commented 1 month ago

@tsegismont Thanks for merging and the quick response!

could you take care of backporting to 4.x?

How do I this? What exactly do you mean?

tsegismont commented 1 month ago

I mean creating another PR for branch 4.x with the same changes.

komape commented 1 month ago

@tsegismont Now I understand. Opened the PR #2659.